This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Distinguish names, refs, and canonical forms #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An image name (e.g., "alpine") is used for different things than an image ref (e.g., "alpine:3.5"). So, be clear about which we're using. For some purposes we want to use the canonical form of an image name or ref; so, make those distinct types as well.
3764145 to
97d1d37
Compare
051dee8 to
068f770
Compare
samb1729
approved these changes
Oct 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An image name (e.g., "alpine") is used for different things than an
image ref (e.g., "alpine:3.5"). So, be clear about which we're using.
For some purposes we want to use the canonical form of an image name
or ref; so, make those distinct types as well.
Imagefrom the start, basically)