This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Wait for platform presence in fluxsvc test #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One source of flakes appears to be the race between the platform being registered and seeing if the platform is registered (both `TestFluxsvc_Register` and `TestFluxsvc_Ping`). This change forces those tests to block until the platform has demonstrably subscribed, or fail if it does not happen within five seconds.
|
If this flakes, I swear ....... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One source of flakes appears to be the race between the platform being registered and seeing if the platform is registered (both
TestFluxsvc_RegisterandTestFluxsvc_Ping).This change forces those tests to block until the platform has demonstrably subscribed, or fail if it does not happen within five seconds.
I've run this a few times in circleci, and although you never know with flakes, it appears to improve the situation. Still a bit of a shot in dim light.