This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Push context deadlines inside jobs and sync ops #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synchronising with the cluster can easily take tens of seconds, so it is better to have timeouts for individual operations or small batches of operations, rather than the whole thing. Similarly, jobs can wait in the job queue for e.g., syncs to happen, so it is necessary to time them from when they _start_, not when they are requested. Lastly, fix and use `git.Repo.NoteRevList` when answering JobStatus from commit notes, since that is exactly the expensive batch of git operations that motivated it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronising with the cluster can easily take tens of seconds, so it is better to have timeouts for individual operations or small batches of operations, rather than the whole thing.
Similarly, jobs can wait in the job queue for e.g., syncs to happen, so it is necessary to time them from when they start, not when they are requested.
Lastly, fix and use
git.Repo.NoteRevListwhen answering JobStatus from commit notes, since that is exactly the expensive batch of git operations that motivated it.