Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Replace docker.io with index.docker.io in ImageID #701

Merged
merged 1 commit into from
Aug 10, 2017

Conversation

samb1729
Copy link
Contributor

Requests to docker.io redirect to www.docker.com rather than index.docker.io, so this change will rewrite image ids to use the latter.

Fixes #692

@samb1729 samb1729 requested a review from squaremo August 10, 2017 13:04
@samb1729 samb1729 force-pushed the replace-docker.io-prefix branch from 6d9b846 to 49be450 Compare August 10, 2017 13:06
@samb1729 samb1729 merged commit f86f7ba into master Aug 10, 2017
@samb1729 samb1729 deleted the replace-docker.io-prefix branch August 10, 2017 13:26
@squaremo
Copy link
Member

It's fine and good this got merged; it made me wonder if there's not a better overall approach to dealing with image names vs where to fetch image manifests.

At the minute we essentially mutate the image name to its canonical form. But this means, for example, that the image names we display in list-images aren't always as supplied by the user, and that can be confusing and might even lead to mistaken copypasta.

So I think it'd be better to keep image names as-is in results, and just use the canonical form where it's needed for fetching things.

@squaremo
Copy link
Member

Created #704

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants