-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add new metric to check if the repository is down or misconfigured #3302
Conversation
Can someone re run the tests? |
@drazul Are you still interested in merging this? If you run The DCO bot has been added to merge checks since this was submitted, if you perform the rebase it should trigger CI once again and the DCO bot will add a link explaining how to sign off your contribution. I am adding this to v1.21.3 milestone since I am not sure if you are still interested in merging it, we will do 1.21.2 imminently for a docs update and this can be discussed then for including in the next release, if you want. |
@kingdonb I just rebased the code to add this change and all checks have been passed. Sorry for the delay. |
Thanks, I will visit this again when preparing for the next milestone release. It may be some time, I want to make a noticeable dent in the open issues on Flux v1 (seriously, like 25-50% or more closed or pending closing) before attempting another release. It appears I can now update your branch with newly minted write access powers I have, as long as there isn't a conflict shown (which it appears there isn't.) I'm going to try that out now 👍 |
go.mod - reset k8s machinery to 1.17.17 This is the latest release that we can update to -- see fluxcd#3378 Try to remove when distribution/distribution#2905 is out docker/distribution patch still needed for now (Put it back for now.) On 2021-02-25 this has been merged, 2.7.2 of docker/distribution should include it hopefully relatively soon! Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Matt Willsher <matt@monki.org.uk> Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Herman Banken <hermanbanken@gmail.com> Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Alaa Qutaish <alaa.qutaish@gmail.com> Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Alex Shpak <alex-shpak@users.noreply.github.com> Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Alex Shpak <alex-shpak@users.noreply.github.com> Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Daniel AguadoAraujo <Daniel.AguadoAraujo@gfk.com>
Signed-off-by: Daniel AguadoAraujo <Daniel.AguadoAraujo@gfk.com>
Rebasing this to include it in #3442 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This Pull Request add a new metric named flux_git_ready.
This new metric can be used to configure an alert when the repository is down or is misconfigured (or any other git error that makes flux mark the repository as not ready).