Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add new metric to check if the repository is down or misconfigured #3302

Merged
merged 17 commits into from
Mar 16, 2021

Conversation

drazul
Copy link
Contributor

@drazul drazul commented Sep 22, 2020

This Pull Request add a new metric named flux_git_ready.

This new metric can be used to configure an alert when the repository is down or is misconfigured (or any other git error that makes flux mark the repository as not ready).

@drazul
Copy link
Contributor Author

drazul commented Sep 29, 2020

Can someone re run the tests?
The failing test is not related with my changes

@kingdonb
Copy link
Member

kingdonb commented Feb 9, 2021

@drazul Are you still interested in merging this? If you run git pull --rebase origin master and git push --force drazul master it should trigger CI to run again.

The DCO bot has been added to merge checks since this was submitted, if you perform the rebase it should trigger CI once again and the DCO bot will add a link explaining how to sign off your contribution.

I am adding this to v1.21.3 milestone since I am not sure if you are still interested in merging it, we will do 1.21.2 imminently for a docs update and this can be discussed then for including in the next release, if you want.

@kingdonb kingdonb added this to the 1.21.3 milestone Feb 9, 2021
@drazul
Copy link
Contributor Author

drazul commented Feb 15, 2021

@kingdonb I just rebased the code to add this change and all checks have been passed.

Sorry for the delay.

@kingdonb
Copy link
Member

Thanks, I will visit this again when preparing for the next milestone release. It may be some time, I want to make a noticeable dent in the open issues on Flux v1 (seriously, like 25-50% or more closed or pending closing) before attempting another release.

It appears I can now update your branch with newly minted write access powers I have, as long as there isn't a conflict shown (which it appears there isn't.) I'm going to try that out now 👍

Kingdon Barrett added 2 commits February 26, 2021 07:22
go.mod - reset k8s machinery to 1.17.17

This is the latest release that we can update to
-- see fluxcd#3378

Try to remove when distribution/distribution#2905 is out

docker/distribution patch still needed for now

(Put it back for now.) On 2021-02-25 this has been merged, 2.7.2 of
docker/distribution should include it hopefully relatively soon!

Signed-off-by: Kingdon Barrett <kingdon@weave.works>
@kingdonb kingdonb modified the milestones: 1.22.1, 1.22.0 Mar 2, 2021
@kingdonb kingdonb self-assigned this Mar 2, 2021
Matt Willsher and others added 15 commits March 3, 2021 08:44
Signed-off-by: Matt Willsher <matt@monki.org.uk>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Herman Banken <hermanbanken@gmail.com>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Alaa Qutaish <alaa.qutaish@gmail.com>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Alex Shpak <alex-shpak@users.noreply.github.com>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Alex Shpak <alex-shpak@users.noreply.github.com>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Kingdon Barrett <kingdon@weave.works>
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
Signed-off-by: Daniel AguadoAraujo <Daniel.AguadoAraujo@gfk.com>
Signed-off-by: Daniel AguadoAraujo <Daniel.AguadoAraujo@gfk.com>
@kingdonb
Copy link
Member

Rebasing this to include it in #3442 👍

Copy link
Member

@kingdonb kingdonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants