Upgrade go version to 1.22 and set version via go.mod in workflow #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good to me, and will also solve one of the issues I had earlier with the api stuff running an older go version than the rest. I still don't know why that was pinned to go 1.19, but it seemed like someone had a reason to do it based on the documentation. @chanwit @yitsushi was there a reason or could we upgrade. Looks like all tests etc are parsing. |
a61afa8 to
a57ea63
Compare
chanwit
approved these changes
Jun 5, 2024
|
Upgrading to v1.22 is fine. Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version upgrade of controller-gen was needed in order to fix issue after the Go version upgrade. The controller-gen upgrade resulted in reformatting of the CRD.