Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch planner is now checking for both PostPlanningWebhookFailedReason and TFExecInitFailedReason for failing PR #1271

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

raz-bn
Copy link
Contributor

@raz-bn raz-bn commented Mar 28, 2024

fixes #1270

…on and TFExecInitFailedReason for failing PR

Signed-off-by: Poodle <52315689+raz-bn@users.noreply.github.com>
@raz-bn raz-bn changed the title branch planner is not checking for both PostPlanningWebhookFailedReason and TFExecInitFailedReason for failing PR branch planner is now checking for both PostPlanningWebhookFailedReason and TFExecInitFailedReason for failing PR Mar 28, 2024
@chanwit chanwit requested a review from yitsushi March 28, 2024 14:53
@chanwit
Copy link
Collaborator

chanwit commented Mar 29, 2024

Thank you @raz-bn
We got many unrelated red in the CI. I'm taking a look at it.

@chanwit
Copy link
Collaborator

chanwit commented Mar 29, 2024

Will resolve this issue first to make the CI green: #1269

@ilithanos
Copy link
Collaborator

@raz-bn could I get you to pull on the latest changes from our main, as that should fix the CI

@raz-bn
Copy link
Contributor Author

raz-bn commented Mar 31, 2024

@ilithanos hey, I updated the branch :)

@ilithanos ilithanos merged commit 8aacbc6 into flux-iac:main Apr 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch planner does not comment of PR if plan failed due to post plan web hook
4 participants