Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump chart and doc yamls to v0.16.0-rc.4 #1242

Merged
merged 2 commits into from
Mar 13, 2024
Merged

bump chart and doc yamls to v0.16.0-rc.4 #1242

merged 2 commits into from
Mar 13, 2024

Conversation

chanwit
Copy link
Collaborator

@chanwit chanwit commented Mar 13, 2024

No description provided.

@chanwit
bump chart and doc yamls to v0.16.0-rc.4
e106a09 
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
@chanwit chanwit requested review from ilithanos and yitsushi March 13, 2024 15:04
@chanwit
make helm-docs
2bce19f 
Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
ilithanos
ilithanos approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@ilithanos ilithanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need a warning somewhere that moving to this chart might delete the CRDs and reapply them the first time this chart is used. After that it should be fine

@chanwit
Copy link
Collaborator Author

chanwit commented Mar 13, 2024

Thank you @ilithanos for bringing that up.
Here's the follow-up ticket: #1243

@chanwit chanwit merged commit adcf570 into main Mar 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilithanos ilithanos ilithanos approved these changes

@yitsushi yitsushi yitsushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanwit @yitsushi @ilithanos