ci: revert to ubuntu-20.04 for workflow jobs that fail on ubuntu-latest #4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Set MWP |
|
Hm, the system test build is getting stuck here: We've seen these issues before, but never in CI, and I didn't think the change here would affect any of the other builds, but I'm looking into it. |
|
My guess is that the |
Problem: The ubuntu-latest image seems to have been recently updated to Ubuntu 22.04, which broke the python linting job, which now does't support python 3.6. Additionally, the system/coverage test build fails because docker-run-systest.sh apparently breaks on 22.04. Use runs-on: ubuntu-20.04 in the python-lint and ci-checks jobs to work around the failures for now.
2dfe0b6 to
67b80a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #4794 +/- ##
==========================================
- Coverage 84.31% 83.46% -0.86%
==========================================
Files 412 415 +3
Lines 62547 70730 +8183
==========================================
+ Hits 52735 59033 +6298
- Misses 9812 11697 +1885
|
|
Oops, I had forgotten to remove MWP when adding ubuntu-20.04 to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The python linting job fails on ubuntu-latest because python 3.6 is no longer supported.
Use runs-on: ubuntu-20.04 in the python-lint job so that python 3.6 can still be used.
See actions/setup-python#355 (comment)