-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(package_info_plus): add install time #3434
feat(package_info_plus): add install time #3434
Conversation
Thanks! I took a quick look and looks promising, thanks for taking the time implementing tests as well. Some ideas to extend this:
|
At first I didn't want to implement this for desktop OSes because the user could easily change files attributes and mess with this, so this shouldn't be used for anything critical like determining a free trial period or anything similar In these cases developers are encouraged to implement this feature in their apps as it fits their needs |
for desktop platforms
refactor(package_info_plus): simplify get file attributes logic
thanks for the recent pushes! let me know when it's ready for review |
I think it is ready, here is a summary of what I decided to do when implementing this for desktop:
I have no idea how can this be implemented on web using only However, It can be implemented by storing the first launch time in local storage or something similar, but I think this should be left out for the developers to choose how they want to implement it What do you think about this? Do you have any suggestions? |
That's fine! Thanks for implementing the other platforms as well. Perhaps install time on web doesn't make much sense, as opposed to the other platforms, the user never installs anything, so it's fair to say this feature is not supported on web. |
Ok great! |
The emulator job is very unstable so it's not mandatory to pass the review. I just need time to look at this (it may take a while) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks specially for investing the time researching support for all platforms and implementing the unit and integration tests!
Tested on Android and Linux, I don't have an Apple computer with me atm, but code seems fine and the integration tests on CI work |
Description
Adds package install time to iOS and Android
PackageManager.firstInstallTime
Related Issues
Checklist
CHANGELOG.md
nor the plugin version inpubspec.yaml
files.flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!
in the title as explained in Conventional Commits).