Skip to content

Commit

Permalink
Merge pull request #304 from lukepighetti/lukepighetti/dec-2022
Browse files Browse the repository at this point in the history
fix CI, add more checks
  • Loading branch information
escamoteur authored Dec 19, 2022
2 parents d2a2901 + 01d6d03 commit 2ac359a
Show file tree
Hide file tree
Showing 9 changed files with 69 additions and 206 deletions.
40 changes: 21 additions & 19 deletions .github/workflows/dart.yml
Original file line number Diff line number Diff line change
@@ -1,28 +1,30 @@
name: Dart CI

on:
push:
branches: [ master ]
branches: [master]
pull_request:
branches: [ master ]
branches: [master]

jobs:
build:

test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2
- name: Install dependencies
run: flutter pub get
- name: Run linter
run: flutter analyze
- name: Run tests
run: flutter test

container:
image: google/dart:latest

format:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install dependencies
run: pub get
- name: Run tests
run: pub run test --coverage

# Code coverage can be acitivated once its ready.
- name: Upload coverage to codecov
uses: codecov/codecov-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2
- run: flutter format .
- uses: stefanzweifel/git-auto-commit-action@v4
with:
commit_message: Update formatted files
file_pattern: "*.dart"
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -485,3 +485,6 @@ DerivedData/
android/local.properties
.vscode/settings.json
example/ios/Flutter/flutter_export_environment.sh

# code coverage files
coverage
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
New features:
* `popScopeTil` got a new optional `inclusive` parameter so you can now decide if scope with the passed name should be popped too or only the ones above
* PR by @jtdLab that adds to reset a LazySingleton by providing an existing instance

* Fix for an internal state error by @ioantsaf
* Fix for a rare edge case if you manually `signalReady`
* Many PRs with improvements to spelling and grammar of readme, source documentation and even one assert message by @selcukguvel @isinghmitesh @UsamaKarim @nilsreichardt and Os-Prog
Expand All @@ -21,12 +20,15 @@ New features:

* fixed bug with manual synchronization of SingletonsWithDependencies
https://github.com/fluttercommunity/get_it/issues/196

## [7.1.3] - 07.05.2021

* Fix for https://github.com/fluttercommunity/get_it/issues/186

## [7.1.2] - 06.05.2021

* Thanks to the clever PR https://github.com/fluttercommunity/get_it/pull/185 by @kmartins `unregister` and `resetLazySingleton` now only have to be awaited if you use an async disposal function.

## [7.1.1] - 05.05.2021

* `pushNewScope()` now got an optional `init` parameter where you can pass a function that registers new objects inside the newly pushed Scope. Doing the registration in this function ensures that the `onScopeChanged` call-back is called after the objects are registered.
Expand Down Expand Up @@ -98,9 +100,11 @@ When the Object is shadowed its `onGetShadowed()` method is called with the obje


* Thanks to this PR https://github.com/fluttercommunity/get_it/pull/181 by @n3wtron you can now also make objects depend on other objects not only by type but also by type and name if you used a named registration

## [6.1.1] - 13.04.2021

* small fix in getAsync with parameters

## [6.1.0] - 12.04.2021

* Exceptions that occur during an async initialisation are now forwarded to the future that `allReady()` returns instead to get swallowed https://github.com/fluttercommunity/get_it/issues/148
Expand All @@ -110,6 +114,7 @@ When the Object is shadowed its `onGetShadowed()` method is called with the obje
## [6.0.0] - 15.02.2021

* Official null safety release

## [5.0.2] - 08.12.2020

* fixed https://github.com/fluttercommunity/get_it/issues/138 when calling `unRegister` the dispose function
Expand Down
156 changes: 0 additions & 156 deletions example/lib/code_for_documentation.dart

This file was deleted.

Loading

0 comments on commit 2ac359a

Please sign in to comment.