Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow video players in Android WebView to maximize from Widget mode #503

Merged

Conversation

mschneider
Copy link
Contributor

Resolving #423 and possibly #279 (I only tested with a mp4 file)

@mschneider
Copy link
Contributor Author

@charafau could you review this PR? Should I also create a patch for the main plugins repo?

@charafau
Copy link
Collaborator

@mschneider thanks for your PR ! For some reason I cannot see updates for repo in github and I'm busy with official webview.

Do you have any example where I can test that changes?

@mschneider
Copy link
Contributor Author

mschneider commented Aug 15, 2019 via email

@charafau
Copy link
Collaborator

@mschneider I needed to revert the changes because of bug I've found:

  1. open the link with video
  2. press fullscreen
  3. click back (it comes back to normal view on webview)
  4. click back again to close webview
  5. it closes whole flutter app <--- should just go back to previous screen

@mschneider
Copy link
Contributor Author

mschneider commented Aug 20, 2019

Confirmed, I started to look into it: seems like the back event is handled directly by flutter and not the native UI.

I'm currently working on a client's project that is not concerned by this issue. I'll prepare a working version at the earliest possible time (possibly only after the launch in early September)

@charafau
Copy link
Collaborator

got it. thanks!

charafau added a commit that referenced this pull request Apr 7, 2020
Allow video players in Android WebView to maximize from Widget mode
@canewsin
Copy link

@mschneider any update ?

@mschneider
Copy link
Contributor Author

no. forgot about it. not sure i'll look into this anytime soon

@jackhax
Copy link

jackhax commented Apr 22, 2020

@mschneider any update?

@canewsin
Copy link

@jackhax

You can use this, based on latest stable.

  flutter_webview_plugin:
    git:
      url: https://github.com/canewsin/flutter_webview_plugin
      ref: fullscreen-support

@Sarthaktydy
Copy link

Is this working or any issues are there?

@rivetingpeppermint
Copy link

rivetingpeppermint commented Aug 5, 2020

I tried @canewsin's fix and it does enable fullscreen, but I had to mash the fullscreen button many times before it opens. Tried with several Android devices, same behavior. I used an embedded YouTube video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants