-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow video players in Android WebView to maximize from Widget mode #503
Allow video players in Android WebView to maximize from Widget mode #503
Conversation
@charafau could you review this PR? Should I also create a patch for the main plugins repo? |
@mschneider thanks for your PR ! For some reason I cannot see updates for repo in github and I'm busy with official webview. Do you have any example where I can test that changes? |
Hi Rafal,
I replaced the target URL of the Webview from flutter.io with
http://clips.vorwaerts-gmbh.de/big_buck_bunny.mp4
and built the example app for Android (&ios).
When opening the webview as a widget the previously grayed out fullscreen
button is now active and can be touched to trigger fullscreen playback. The
back button correctly closes the fullscreen view again.
Best,
Max
…On Thu 15. Aug 2019 at 13:36, Rafal Wachol ***@***.***> wrote:
@mschneider <https://github.com/mschneider> thanks for your PR ! For some
reason I cannot see updates for repo in github and I'm busy with official
webview.
Do you have any example where I can test that changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#503?email_source=notifications&email_token=AABDF7D6WQSP3J75VBFYKGLQEU5S3A5CNFSM4IKMNXCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4LSS2Q#issuecomment-521611626>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABDF7DNRJFAUZ2SVGVGDWLQEU5S3ANCNFSM4IKMNXCA>
.
|
@mschneider I needed to revert the changes because of bug I've found:
|
Confirmed, I started to look into it: seems like the back event is handled directly by flutter and not the native UI. I'm currently working on a client's project that is not concerned by this issue. I'll prepare a working version at the earliest possible time (possibly only after the launch in early September) |
got it. thanks! |
Allow video players in Android WebView to maximize from Widget mode
@mschneider any update ? |
no. forgot about it. not sure i'll look into this anytime soon |
@mschneider any update? |
You can use this, based on latest stable.
|
Is this working or any issues are there? |
I tried @canewsin's fix and it does enable fullscreen, but I had to mash the fullscreen button many times before it opens. Tried with several Android devices, same behavior. I used an embedded YouTube video. |
Resolving #423 and possibly #279 (I only tested with a mp4 file)