-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for More debugging options in DevTools #6975
Conversation
 | ||
|
||
## More debugging options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a note that users will have to reproduce activity in their app to see differences in performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of paragraphs
reproduce the activity in your app, | ||
select the new frames in the frames chart, | ||
to inspect the timeline events | ||
with the layers disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a sentence here that says. "If Paint time or Raster time has significantly decreased, excessive use of the effects you disabled may be contributing to the jank you saw in your app."
@dnfield can you check me here - if a user disables clip layers and sees a performance improvement, where is that improvement likely to show up? In the Paint event on the UI thread? In the raster events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @dnfield . and is this true for all the layer options here? (clip, opacity, physical shape)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, yes - although some build time improvements on the UI thread may be noted, these are things that have more impact on raster time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(i.e. clipping (especially clipping with anti-aliasing if it is requested), saving layers, drawing shadows)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a sentence for this in fe1a818
Add a sentence to clarify that raster time is mostly affected when layers are disabled in DevTools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small tweak, then lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like one more small tweak is needed (paint or raster => raster), then LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few little format/word things, but otherwise LGTM
This adds documentation for the "More debugging options" in Devtools.
cc: @kenzieschmoll
fixes #6750
Presubmit checklist