You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
Added basic support to load html data on both platform
[webview_flutter] Added basic support to load html data on both platform
Feb 22, 2019
Thanks for the contribution, and sorry for the long time it took me to respond!
I'd be hesitant to add htmlData as a widget parameter, e.g what does it mean after loadUrl is called on a widget that was built with htmlData? (I think this should be an edge trigger rather than a level trigger, you can find some information about these kind of issues in this article)
We'd also want an e2e test before we can land this.
I filed flutter/flutter#32827 to track this issue and mentioned this PR there.
I'm going to close this PR, if you're still interested in working on this feel free to re-open (or send a new one) after changing it to an edge trigger(I put up an API proposal on the issue) and adding tests.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title suggests, added basic support to load html data on both platform.