[webview_flutter] Support for handling basic authentication requests (Android) #5454

JeroenWeener · 2023-11-21T11:48:10Z

Adds the Android implementation for basic http authentication.

This PR is part of a series of PRs that aim to close flutter/flutter#83556.
The PR that contains all changes can be found at #4140.

Pre-launch Checklist

…/packages into webview-auth-request

…b/src/types/http_auth_request.dart

…request

…s into webview-auth-request

rekire · 2023-11-25T09:49:25Z

FYI: There is a similar PR for other dialogs #4704

bparrishMines

Everything looks good. Just need to update the pubspecs.

bparrishMines · 2023-11-28T00:48:26Z

packages/webview_flutter/webview_flutter_android/example/pubspec.yaml

+
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
+# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
+dependency_overrides:
+   {webview_flutter_android: {path: ../../../webview_flutter/webview_flutter_android}, webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}}


This can be removed and the minimum version of the webview_flutter_platform_interface should be bumped to ^2.7.0.

Suggested change

# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.

# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

dependency_overrides:

{webview_flutter_android: {path: ../../../webview_flutter/webview_flutter_android}, webview_flutter_platform_interface: {path: ../../../webview_flutter/webview_flutter_platform_interface}}

bparrishMines · 2023-11-28T00:49:49Z

packages/webview_flutter/webview_flutter_android/pubspec.yaml

+
+# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.
+# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins
+dependency_overrides:
+   {webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}}


This should be removed too.

Suggested change

# FOR TESTING AND INITIAL REVIEW ONLY. DO NOT MERGE.

# See https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

dependency_overrides:

{webview_flutter_platform_interface: {path: ../../webview_flutter/webview_flutter_platform_interface}}

bparrishMines

LGTM

@stuartmorgan for secondary review

stuartmorgan · 2023-11-29T18:54:47Z

packages/webview_flutter/webview_flutter_android/lib/src/android_webview_controller.dart

+      ) {
+        final void Function(HttpAuthRequest)? callback =
+            weakThis.target?._onHttpAuthRequest;
+        if (callback != null) {


Don't we need a default reply when there's no handler like we have on iOS?

That's a good catch. I updated the PR

…request-android

stuartmorgan

LGTM

It would be good to have a test that the default handler is there and works (i.e., one that would have failed before the fix made for my previous comment), but that could be a follow-up.

…(Android) (flutter#5454) Adds the Android implementation for basic http authentication. This PR is part of a series of PRs that aim to close flutter/flutter#83556. The PR that contains all changes can be found at flutter#4140.

…equests (Android) (flutter/packages#5454)

flutter/packages@b5958e2...1151191 2023-12-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.8 to 3.22.11 (flutter/packages#5674) 2023-12-13 ditman@gmail.com [ci][web] Ignore always_specify_types for JSArray. (flutter/packages#5669) 2023-12-13 mikemcguiness@protonmail.com [tool] Add support for `.java`, `.gradle`, `.sh`, and `.m` filesâ�¦ (flutter/packages#5567) 2023-12-13 ditman@gmail.com [google_sign_in] Update (web) example app. (flutter/packages#5634) 2023-12-13 34871572+gmackall@users.noreply.github.com [path_provider] De-flake getExternalStorageDirectories test (flutter/packages#5628) 2023-12-13 ditman@gmail.com [google_sign_in_web] Stop relying on framework internals. (flutter/packages#5660) 2023-12-13 43054281+camsim99@users.noreply.github.com [Android] Bump Gradle version to 7.6.3 (flutter/packages#5522) 2023-12-13 mikemcguiness@protonmail.com [google_sign_in] Adopt code excerpts in README (flutter/packages#5521) 2023-12-13 mikemcguiness@protonmail.com [css_colors] Adopt code excerpts in README (flutter/packages#5478) 2023-12-13 JeroenWeener@users.noreply.github.com [webview_flutter] Support for handling basic authentication requests (Android) (flutter/packages#5454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…s cancelled by default (#5723) Added test in response to feedback from #5454 (review) Also regenerates mock files.

…5727) ## Description This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are #5362, #5454 and #5455. Issues fixed by PR: Closes flutter/flutter#83556

…(Android) (flutter#5454) Adds the Android implementation for basic http authentication. This PR is part of a series of PRs that aim to close flutter/flutter#83556. The PR that contains all changes can be found at flutter#4140.

…s cancelled by default (flutter#5723) Added test in response to feedback from flutter#5454 (review) Also regenerates mock files.

…lutter#5727) ## Description This pull request exposes the Android and iOS HTTP Basic Authentication feature to users of the `webview_flutter` plugin. It is the final PR in a sequence of PRs. Previous PRs are flutter#5362, flutter#5454 and flutter#5455. Issues fixed by PR: Closes flutter/flutter#83556

JeroenWeener and others added 30 commits October 26, 2023 11:23

Implement http basic auth

517e9d4

Apply feedback

967879b

Create HttpAuthHandlerTest.java

c8624c0

Format java files

4f3574d

Regenerate build_runner files

1e7f785

Implement feedback

131bc56

Remove redundant key in Info.plist

bc01be4

Update example apps

67aa00e

Implement http basic auth

32496d0

Apply feedback

aeb8708

Create HttpAuthHandlerTest.java

fffc4c7

Format java files

b455040

Regenerate build_runner files

2aa9bfe

Implement feedback

db286ba

Remove redundant key in Info.plist

467feb3

Update example apps

dad8ae6

Merge branch 'webview-auth-request' of https://github.com/andreisas06…

6f3d802

…/packages into webview-auth-request

Add platform interface dev dependency to example

0fef591

Merge branch 'main' into webview-auth-request

b2a4fbb

Update packages/webview_flutter/webview_flutter_platform_interface/li…

ce35d9b

…b/src/types/http_auth_request.dart

Merge branch 'main' of github.com:flutter/packages into webview-auth-…

fc32898

…request

Merge branch 'webview-auth-request' of github.com:andreisas06/package…

4673e65

…s into webview-auth-request

Fix some lints, errros and call on errors

580521a

fix lints

d1f305b

fix tests

a3f74be

add onProceed and onCancel back

ed3798f

dont require realm to be nonnull

154c1f8

add line back

3c61dbc

Merge remote-tracking branch 'upstream/main' into webview-auth-request

7cf0d7e

Update changelogs

a21f29a

github-actions bot removed the platform-ios label Nov 21, 2023

JeroenWeener marked this pull request as ready for review November 21, 2023 11:51

JeroenWeener requested a review from bparrishMines as a code owner November 21, 2023 11:51

bparrishMines requested changes Nov 28, 2023

View reviewed changes

Update pubspecs

5c8ecc1

JeroenWeener requested a review from bparrishMines November 28, 2023 08:39

bparrishMines approved these changes Nov 29, 2023

View reviewed changes

stuartmorgan reviewed Nov 29, 2023

View reviewed changes

bparrishMines added 2 commits December 5, 2023 14:40

cancel by default

60fe593

Merge branch 'main' of github.com:flutter/packages into webview-auth-…

605833c

…request-android

stuartmorgan approved these changes Dec 13, 2023

View reviewed changes

stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 13, 2023

auto-submit bot merged commit 2c54697 into flutter:main Dec 13, 2023

engine-flutter-autoroll mentioned this pull request Dec 14, 2023

Roll Packages from b5958e2a8b49 to 1151191c8c13 (10 revisions) flutter/flutter#140154

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2023

2c54697 [webview_flutter] Support for handling basic authentication r…

0dc750a

…equests (Android) (flutter/packages#5454)

bparrishMines mentioned this pull request Dec 19, 2023

[webview_flutter_android] Add test that onReceivedHttpAuthRequest is cancelled by default #5723

Merged

11 tasks

JeroenWeener mentioned this pull request Dec 20, 2023

[webview_flutter] Support for handling basic authentication requests #5727

Merged

11 tasks

reidbaker mentioned this pull request Jan 12, 2024

Dialog Debug #5881

Closed

auto-submit bot pushed a commit that referenced this pull request Jan 13, 2024

[webview_flutter_android] Add test that onReceivedHttpAuthRequest i…

dea6c73

…s cancelled by default (#5723) Added test in response to feedback from #5454 (review) Also regenerates mock files.

reidbaker mentioned this pull request Jan 19, 2024

[in_app_purchase] Add play country code api #5941

Merged

12 tasks

reidbaker mentioned this pull request Feb 19, 2024

[in_app_purchase_android] Add UserChoiceBilling mode. #6162

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter] Support for handling basic authentication requests (Android) #5454

[webview_flutter] Support for handling basic authentication requests (Android) #5454

JeroenWeener commented Nov 21, 2023

rekire commented Nov 25, 2023

bparrishMines left a comment

bparrishMines Nov 28, 2023

bparrishMines Nov 28, 2023

bparrishMines left a comment

stuartmorgan Nov 29, 2023

bparrishMines Dec 5, 2023

stuartmorgan left a comment

[webview_flutter] Support for handling basic authentication requests (Android) #5454

[webview_flutter] Support for handling basic authentication requests (Android) #5454

Conversation

JeroenWeener commented Nov 21, 2023

Pre-launch Checklist

rekire commented Nov 25, 2023

bparrishMines left a comment

Choose a reason for hiding this comment

bparrishMines Nov 28, 2023

Choose a reason for hiding this comment

bparrishMines Nov 28, 2023

Choose a reason for hiding this comment

bparrishMines left a comment

Choose a reason for hiding this comment

stuartmorgan Nov 29, 2023

Choose a reason for hiding this comment

bparrishMines Dec 5, 2023

Choose a reason for hiding this comment

stuartmorgan left a comment

Choose a reason for hiding this comment