-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gen_l10n] Create pubspec.yaml in ".dart_tool/flutter_gen" if it does not already exist #68206
Conversation
@@ -2,6 +2,10 @@ | |||
// Use of this source code is governed by a BSD-style license that can be | |||
// found in the LICENSE file. | |||
|
|||
const String emptyPubspecTemplate = '''name: synthetic_package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this also needs to have an SDK constraint too? I'm not sure if build will prefer the one in the package_config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build_runner
exception no longer appears with a pubspec that does not specify an SDK constraint. Could you clarify what you mean by build preferring the one in package_config over providing one here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it doesn't happen at all, then I would leave this as minimal as possible and with a comment what generated it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with question
This change looks small, can this be picked into a 1.22 hotfix? |
Since there's a workaround for this and it's not a breaking regression, I don't think it fits into the description of a hotfix: https://github.com/flutter/flutter/wiki/Hotfixes-to-the-Stable-Channel |
Fixes dart-lang/build#2835
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.