Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't require diffs to have a percentage coverage greater #36090

Merged
merged 1 commit into from
Jul 12, 2019
Merged

don't require diffs to have a percentage coverage greater #36090

merged 1 commit into from
Jul 12, 2019

Conversation

jonahwilliams
Copy link
Member

@jonahwilliams jonahwilliams commented Jul 12, 2019 •
edited
Loading

Than the previous diff

@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygine page and make sure this patch meets those guidelines before LGTMing.

/cc @dnfield

@jonahwilliams jonahwilliams changed the title don't require diffs to have a percentage coverage greater than the pre… don't require diffs to have a percentage coverage greater Jul 12, 2019
@jonahwilliams jonahwilliams added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Jul 12, 2019
@jonahwilliams jonahwilliams requested a review from dnfield July 12, 2019 19:25
@jonahwilliams
Copy link
Member Author

@dnfield the test bot should probably ignore non-dart files

@dnfield dnfield mentioned this pull request Jul 12, 2019
Merged
dnfield
dnfield approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams mentioned this pull request Jul 12, 2019
Merged
@jonahwilliams jonahwilliams merged commit 9d31c2a into flutter:master Jul 12, 2019
@jonahwilliams jonahwilliams deleted the fix_codecov_more branch July 12, 2019 22:10
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
@jonahwilliams @johnsonmh
dont require diffs to have a percentage coverage greater than the pre…
caf6cdc 
…vious diff (flutter#36090)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonahwilliams @fluttergithubbot @dnfield @googlebot