Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark flutter_gallery__preview_dart_2_bulid unflaky #13170

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

cbracken
Copy link
Member

@cbracken cbracken commented Nov 23, 2017

This was fixed in #13150.

That commit rolled the engine to:
flutter/engine@93b2179,

which rolled Dart to:
dart-lang/sdk@70e5dea

which includes:
dart-lang/sdk@d38c08d

Which fixes the breakage introduced in #13134.

This reverts commit f5d9c77.

This was fixed in d79c12e.

This reverts commit f5d9c77.
@cbracken cbracken requested a review from aam November 23, 2017 01:52
@yjbanov
Copy link
Contributor

yjbanov commented Nov 23, 2017

lgtm

@cbracken cbracken merged commit 112df6e into flutter:master Nov 23, 2017
@cbracken cbracken deleted the unflake branch November 23, 2017 02:17
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
This was fixed in flutter#13150.

That commit rolled the engine to:
  flutter/engine@93b2179,

which rolled Dart to:
  dart-lang/sdk@70e5dea

which includes:
  dart-lang/sdk@d38c08d

Which fixes the breakage introduced in flutter#13134.

This reverts commit f5d9c77.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants