[iOS] keep threads merged when using Skia renderer on iOS #54514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
cbracken
reviewed
Aug 12, 2024
shell/platform/darwin/ios/framework/Source/platform_views_controller.mm
Outdated
Show resolved
Hide resolved
…roller.mm Co-authored-by: Chris Bracken <chris@bracken.jp>
cbracken
approved these changes
Aug 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 13, 2024
…153326) flutter/engine@5d8ee52...07ecd90 2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from c9fd814b106a to 7bed8fb6fae2 (2 revisions) (flutter/engine#54516) 2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from e232752d04c5 to c9fd814b106a (3 revisions) (flutter/engine#54515) 2024-08-12 43054281+camsim99@users.noreply.github.com [Android] Update integration test AVD dependency to use Android 35 emulators (flutter/engine#54186) 2024-08-12 jonahwilliams@google.com [iOS] keep threads merged when using Skia renderer on iOS (flutter/engine#54514) 2024-08-12 chris@bracken.jp iOS,macOS: Clean up create_ios_framework.py (flutter/engine#54500) 2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from ec7558d41b34 to e232752d04c5 (3 revisions) (flutter/engine#54511) 2024-08-12 skia-flutter-autoroll@skia.org Roll Dart SDK from cfe2b63d3aca to a6cd8099ff85 (1 revision) (flutter/engine#54512) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…lutter#153326) flutter/engine@5d8ee52...07ecd90 2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from c9fd814b106a to 7bed8fb6fae2 (2 revisions) (flutter/engine#54516) 2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from e232752d04c5 to c9fd814b106a (3 revisions) (flutter/engine#54515) 2024-08-12 43054281+camsim99@users.noreply.github.com [Android] Update integration test AVD dependency to use Android 35 emulators (flutter/engine#54186) 2024-08-12 jonahwilliams@google.com [iOS] keep threads merged when using Skia renderer on iOS (flutter/engine#54514) 2024-08-12 chris@bracken.jp iOS,macOS: Clean up create_ios_framework.py (flutter/engine#54500) 2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from ec7558d41b34 to e232752d04c5 (3 revisions) (flutter/engine#54511) 2024-08-12 skia-flutter-autoroll@skia.org Roll Dart SDK from cfe2b63d3aca to a6cd8099ff85 (1 revision) (flutter/engine#54512) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#153326) flutter/engine@5d8ee52...07ecd90 2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from c9fd814b106a to 7bed8fb6fae2 (2 revisions) (flutter/engine#54516) 2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from e232752d04c5 to c9fd814b106a (3 revisions) (flutter/engine#54515) 2024-08-12 43054281+camsim99@users.noreply.github.com [Android] Update integration test AVD dependency to use Android 35 emulators (flutter/engine#54186) 2024-08-12 jonahwilliams@google.com [iOS] keep threads merged when using Skia renderer on iOS (flutter/engine#54514) 2024-08-12 chris@bracken.jp iOS,macOS: Clean up create_ios_framework.py (flutter/engine#54500) 2024-08-12 skia-flutter-autoroll@skia.org Roll Skia from ec7558d41b34 to e232752d04c5 (3 revisions) (flutter/engine#54511) 2024-08-12 skia-flutter-autoroll@skia.org Roll Dart SDK from cfe2b63d3aca to a6cd8099ff85 (1 revision) (flutter/engine#54512) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for money crasher.