Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testing/litetest to pub workspaces. #54082

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

matanlurey
Copy link
Contributor

More incremental version of #53997.

@matanlurey matanlurey requested a review from jonahwilliams July 24, 2024 17:31
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2024
Copy link
Contributor

auto-submit bot commented Jul 24, 2024

auto label is removed for flutter/engine/54082, due to - The status or check suite Linux linux_fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2024
@matanlurey matanlurey requested a review from jason-simmons July 24, 2024 19:33
# In all other cases we default to "2.8"
env_sdk = parsed.get('environment', {}).get('sdk', 'any')
match = re.search(r'^(>=)?((0|[1-9]\d*)\.(0|[1-9]\d*))', env_sdk)
match = re.search(r'^(>=|^)?((0|[1-9]\d*)\.(0|[1-9]\d*))', env_sdk)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caret character will need to be escaped: (>=|\^)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2024
Copy link
Contributor

auto-submit bot commented Jul 24, 2024

auto label is removed for flutter/engine/54082, due to - The status or check suite Linux local_engine_builds has failed. Please fix the issues identified (or deflake) before re-applying this label.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2024
@auto-submit auto-submit bot merged commit bb2ff8b into flutter:main Jul 24, 2024
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 24, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 25, 2024
…152278)

flutter/engine@4b95209...eb8fac2

2024-07-24 chris@bracken.jp [iOS] Build universal gen_snapshots for iOS (flutter/engine#54009)
2024-07-24 matanlurey@users.noreply.github.com Move testing/litetest to pub workspaces. (flutter/engine#54082)
2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 1561e2127c6f to 54d1434637a1 (2 revisions) (flutter/engine#54087)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#152278)

flutter/engine@4b95209...eb8fac2

2024-07-24 chris@bracken.jp [iOS] Build universal gen_snapshots for iOS (flutter/engine#54009)
2024-07-24 matanlurey@users.noreply.github.com Move testing/litetest to pub workspaces. (flutter/engine#54082)
2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 1561e2127c6f to 54d1434637a1 (2 revisions) (flutter/engine#54087)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#152278)

flutter/engine@4b95209...eb8fac2

2024-07-24 chris@bracken.jp [iOS] Build universal gen_snapshots for iOS (flutter/engine#54009)
2024-07-24 matanlurey@users.noreply.github.com Move testing/litetest to pub workspaces. (flutter/engine#54082)
2024-07-24 skia-flutter-autoroll@skia.org Roll Skia from 1561e2127c6f to 54d1434637a1 (2 revisions) (flutter/engine#54087)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-fuchsia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants