Embedder VsyncWaiter must schedule a frame for the right time #29408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to flutter#28817 super class vsync waiter would post the tast to the future if the frame start time is at a later poit. This change made it so that the sub classes are responsible for posting the task at the right time. This change makes it so that vsync waiter embedder respects that contract. Fixes flutter/flutter#92603
chinmaygarde
approved these changes
Nov 1, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2021
godofredoc
added a commit
that referenced
this pull request
Nov 3, 2021
#29508) * Embedder VsyncWaiter must schedule a frame for the right time (#29408) * Ensure vsync callback completes before resetting the engine. (#29488) Fixes: flutter/flutter#92934 Co-authored-by: Kaushik Iska <iska.kaushik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #28817 super class vsync waiter would post the tast to the future if the frame start time is at a later poit. This change made it so that the sub classes are responsible for posting the task at the right time.
This change makes it so that vsync waiter embedder respects that contract.
Fixes flutter/flutter#92603