final review comments

flutter · Jan 20, 2022 · ced28ed · ced28ed
1 parent 7779b61
commit ced28ed
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/shell/platform/darwin/macos/framework/Headers/FlutterPlatformViews.h b/shell/platform/darwin/macos/framework/Headers/FlutterPlatformViews.h
@@ -20,16 +20,13 @@
  *
  * The implementation of this method should create a new `NSView`.
  *
- * @param frame The rectangle for the newly created view measured in points.
  * @param viewId A unique identifier for this view.
  * @param args Parameters for creating the view sent from the Dart side of the
  * Flutter app. If `createArgsCodec` is not implemented, or if no creation arguments were sent from
  * the Dart code, this will be null. Otherwise this will be the value sent from the Dart code as
  * decoded by `createArgsCodec`.
  */
-- (nonnull NSView*)createWithFrame:(CGRect)frame
-                    viewIdentifier:(int64_t)viewId
-                         arguments:(nullable id)args;
+- (nonnull NSView*)createWithviewIdentifier:(int64_t)viewId arguments:(nullable id)args;
 
 /**
  * Returns the `FlutterMessageCodec` for decoding the args parameter of `createWithFrame`.

diff --git a/shell/platform/darwin/macos/framework/Source/FlutterMetalCompositor.mm b/shell/platform/darwin/macos/framework/Source/FlutterMetalCompositor.mm
@@ -107,6 +107,7 @@
 
 void FlutterMetalCompositor::PresentPlatformView(const FlutterLayer* layer, size_t layer_position) {
   // TODO (https://github.com/flutter/flutter/issues/96668)
+  // once the issue is fixed, this check will pass.
   FML_DCHECK([[NSThread currentThread] isMainThread])
       << "Must be on the main thread to present platform views";
 

diff --git a/shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm b/shell/platform/darwin/macos/framework/Source/FlutterPlatformViewController.mm
@@ -44,7 +44,7 @@ - (void)onCreateWithViewID:(int64_t)viewId
     return;
   }
 
-  NSView* platform_view = [factory createWithFrame:CGRectZero viewIdentifier:viewId arguments:nil];
+  NSView* platform_view = [factory createWithviewIdentifier:viewId arguments:nil];
   _platformViews[viewId] = platform_view;
   result(nil);
 }

diff --git a/shell/platform/darwin/macos/framework/Source/TestFlutterPlatformView.mm b/shell/platform/darwin/macos/framework/Source/TestFlutterPlatformView.mm
@@ -17,10 +17,8 @@ - (instancetype)initWithFrame:(CGRect)frame {
 @end
 
 @implementation TestFlutterPlatformViewFactory
-- (NSView*)createWithFrame:(CGRect)frame
-            viewIdentifier:(int64_t)viewId
-                 arguments:(nullable id)args {
-  return [[TestFlutterPlatformView alloc] initWithFrame:frame];
+- (NSView*)createWithviewIdentifier:(int64_t)viewId arguments:(nullable id)args {
+  return [[TestFlutterPlatformView alloc] initWithFrame:CGRectZero];
 }
 
 - (NSObject<FlutterMessageCodec>*)createArgsCodec {