Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify pull request in DCM workflow #5727

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Specify pull request in DCM workflow #5727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4873d7
Specify pull request in DCM workflow
elliette Apr 27, 2023
9bf10ee
Delete clone step from flutter-prep
elliette Apr 27, 2023
3cff804
Flutter prep fix
elliette Apr 27, 2023
2e25956
Provide input to flutter-prep workflow
elliette Apr 27, 2023
cc58b7a
Remove extra steps
elliette Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/dcm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,17 @@ jobs:
uses: ./.github/workflows/flutter-prep.yaml
with:
os-name: ubuntu
needs-checkout-merge: true

dcm:
name: Dart Code Metrics
needs: flutter-prep
runs-on: ubuntu-latest
steps:
- name: Clone Flutter DevTools
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
with:
ref: "refs/pull/${{ github.event.number }}/merge"
- name: Load Cached Flutter SDK
uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8
with:
Expand Down
19 changes: 18 additions & 1 deletion .github/workflows/flutter-prep.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ on:
os-name:
description: 'The OS to run against, either "macos" or "ubuntu". If neither is provided, will run against both.'
type: string
needs-checkout-merge:
description: 'Whether the PR should be merged during the checkout step. Necessary for pull_request_target workflows.'
type: boolean
outputs:
latest_flutter_candidate:
description: 'The latest Flutter candidate version.'
Expand All @@ -25,7 +28,21 @@ jobs:
os: ${{ (inputs.os-name == 'macos' && fromJSON('[ "macos-latest"]')) || (inputs.os-name == 'ubuntu' && fromJSON('[ "ubuntu-latest"]')) || fromJSON('["ubuntu-latest", "macos-latest"]') }}
runs-on: ${{ matrix.os }}
steps:
- name: git clone devtools
# TODO(https://github.com/flutter/devtools/issues/5729) Consider caching DevTools so that we
# don't check it out again is subsequent workflows.

# Merge in the PR branch during checkout. This is necessary for pull_request_target workflows.
# See: https://github.com/actions/checkout/issues/518
- name: Checkout PR branch for DevTools
if: ${{ inputs.needs-checkout-merge == true }}
id: checkout-pr-branch
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
with:
ref: "refs/pull/${{ github.event.number }}/merge"

# Otherwise use the default checkout action.
- name: Checkout DevTools (default)
if: steps.checkout-pr-branch.outcome == 'skipped'
uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab

- name: Get Latest Flutter Candidate
Expand Down