Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate provider screen to null-safety #3915

Merged
merged 21 commits into from
Apr 11, 2022
Merged

Migrate provider screen to null-safety #3915

merged 21 commits into from
Apr 11, 2022

Conversation

rrousselGit
Copy link
Contributor

@rrousselGit rrousselGit commented Mar 24, 2022 •
edited
Loading

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@rrousselGit rrousselGit mentioned this pull request Mar 24, 2022
Closed
@kenzieschmoll
Copy link
Member

Hi @rrousselGit! Thank you for working on this! Just let us know when this is ready for review and we'll get right on it.

@polina-c
Copy link
Contributor

@rrousselGit , if you convert this PR from draft to 'Ready for review' the bots should run the tests and take this toil from you.

@rrousselGit
Copy link
Contributor Author

Indeed. Although the tests are currently failing, so I felt like "draft" was appropriate

@rrousselGit rrousselGit marked this pull request as ready for review March 31, 2022 19:19
polina-c
polina-c reviewed Mar 31, 2022
View reviewed changes
@rrousselGit
Copy link
Contributor Author

I believe I've applied all your suggestions.

Although tests are still failing I believe. But I believe the CI is skipping the tests, so it's green anyway.
I'll investigate

@rrousselGit
Copy link
Contributor Author

Alright, I've fixed all the tests (even though the CI doesn't seem to run them).

This should be good to merge

@rrousselGit rrousselGit requested a review from polina-c April 10, 2022 09:15
kenzieschmoll
kenzieschmoll approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple nits about imports, then LGTM. Fine to land import fixes in a follow up CL

packages/devtools_app/test/provider/provider_controller_test.dart Outdated
// ignore_for_file: import_of_legacy_library_into_null_safe

// ignore: import_of_legacy_library_into_null_safe
import 'package:devtools_app/devtools_app.dart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should import libraries directly instead of importing devtools_app.dart, which exports many libraries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, done

packages/devtools_app/test/provider/provider_controller_test.dart Outdated
import '../test_infra/flutter_test_driver.dart';
// ignore: import_of_legacy_library_into_null_safe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of repeating // ignore: import_of_legacy_library_into_null_safe, just revert back to using ignore_for_file at the top of the file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that all the ignores could be removed after-all. So I did that instead

@kenzieschmoll kenzieschmoll merged commit e2b1deb into flutter:master Apr 11, 2022
@kenzieschmoll
Copy link
Member

Merged. Thanks @rrousselGit!

@rrousselGit rrousselGit deleted the upgrade-dependencies branch April 11, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polina-c polina-c polina-c left review comments

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rrousselGit @kenzieschmoll @polina-c