Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate inspector_service to null safety. #3854

Merged
merged 10 commits into from
Mar 17, 2022
Merged

Migrate inspector_service to null safety. #3854

merged 10 commits into from
Mar 17, 2022

Conversation

polina-c
Copy link
Contributor

No description provided.

@polina-c polina-c marked this pull request as ready for review March 15, 2022 19:44
@polina-c polina-c marked this pull request as draft March 16, 2022 22:55
@polina-c polina-c marked this pull request as ready for review March 16, 2022 23:13
@polina-c polina-c marked this pull request as draft March 17, 2022 18:16
@polina-c polina-c marked this pull request as ready for review March 17, 2022 18:41

@visibleForTesting
final Map<String?, ClassRef> localClasses = {};
final Map<String, ClassRef> localClasses = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: type on RHS

@@ -942,7 +960,7 @@ abstract class ObjectGroupBase implements Disposable {
final clazz = await inspectorLibrary.getClass(instance.classRef!, this);
if (disposed || clazz == null) return null;

final Map<String?, InstanceRef?> properties = {};
final Map<String, InstanceRef?> properties = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type on RHS

@polina-c
Copy link
Contributor Author

tested

@polina-c polina-c merged commit 006e36d into flutter:master Mar 17, 2022
@polina-c polina-c deleted the is branch March 17, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants