Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate table_data.dart to null safety. #3685

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Migrate table_data.dart to null safety. #3685

merged 4 commits into from
Feb 15, 2022

Conversation

polina-c
Copy link
Contributor

No description provided.

@polina-c polina-c marked this pull request as ready for review February 14, 2022 22:49
@polina-c polina-c marked this pull request as draft February 15, 2022 16:37
@polina-c polina-c marked this pull request as ready for review February 15, 2022 17:20
kenzieschmoll
kenzieschmoll reviewed Feb 15, 2022
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment •
edited by polina-c
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took a closer look at this code. Looks like the classes HoverCellData, TableDataClient, TableData and TreeTableData aren't used anywhere in DevTools. Let's delete those classes.

Polina: done

@polina-c
Copy link
Contributor Author

tested

@polina-c polina-c merged commit 1926efe into flutter:master Feb 15, 2022
@polina-c polina-c deleted the td branch February 15, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polina-c @kenzieschmoll