Migrate scaffold.dart to null safety. #3666
Conversation
| Widget flexibleSpace; | ||
| Size preferredSize; | ||
| Widget? flexibleSpace; | ||
| late Size preferredSize; |
There was a problem hiding this comment.
preferred size will never be initialized if widget.tabs.length <= 1, so I think this should be nullable
There was a problem hiding this comment.
the method will return early in this case. reformatted the code to make it clearer
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| // @dart=2.9 | |||
|
|
|||
| // ignore_for_file: avoid_redundant_argument_values | |||
There was a problem hiding this comment.
we don't want to add these ignores. If you are getting warnings locally but not on the bots, try switching your local flutter version to the version specified in flutter-version.txt
There was a problem hiding this comment.
My flutter version is equal to one in flutter-version.txt.
I get this warning for the files that are not migrated yet to 2.12 and that reference migrated ones. I plan to remove the annotations when I migrate the files.
|
tested |
|
tested |
No description provided.