Migrate theme.dart to be null safe. #3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/devtools_app/lib/src/debugger/program_explorer_controller.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Feb 8, 2022
kenzieschmoll
approved these changes
Feb 8, 2022
| @@ -12,17 +12,6 @@ import 'package:flutter_test/flutter_test.dart'; | |||
| void main() { | |||
| group('Theme', () { | |||
| ThemeData theme; | |||
| test('can be used without override', () { | |||
| theme = themeFor(isDarkTheme: true, ideTheme: null); | |||
There was a problem hiding this comment.
instead of removing this test, why don't we just replace null with IdeTheme()?
There was a problem hiding this comment.
The goal of the test is to verify everything works with null. We do not need this validation any more.
Other tests here cover non-null cases. Makes sense?
There was a problem hiding this comment.
In this case an empty IdeTheme would be the equivalent of what used to be null, in terms of testing the "without override" case. The "without override" case is where a user runs DevTools via dart devtools instead of using the DevTools embedded in their IDE. So we still want to test the case where IdeTheme does not contain overrides for backgroundColor, foregroundColor, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.