Migrate linked_scroll_controller to null safety. #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/devtools_app/lib/src/primitives/flutter_widgets/linked_scroll_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/primitives/flutter_widgets/linked_scroll_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/primitives/flutter_widgets/linked_scroll_controller.dart
Outdated
Show resolved
Hide resolved
| @@ -372,14 +370,14 @@ class _LinkedScrollActivity extends ScrollActivity { | |||
|
|
|||
| void _updateUserScrollDirection() { | |||
| assert(drivers.isNotEmpty); | |||
| ScrollDirection commonDirection; | |||
| ScrollDirection? commonDirection; | |||
There was a problem hiding this comment.
this looks like it can be late instead of nullable
There was a problem hiding this comment.
It cannot because the line "commonDirection ??= driver.userScrollDirection" first read and then initializes.
kenzieschmoll
approved these changes
Feb 4, 2022
|
tested functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.