Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_embedded dimension to DevTools analytics #3522

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

kenzieschmoll
Copy link
Member

This will allow us to see whether a user is using the embedded version of DevTools in an IDE. We already have information as to which IDE a user is using from the ?ide= query parameter

Copy link
Contributor

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

(I don't know if dimension10 needs adding to some analytics account somewhere, but I presume if it does that will be done too)

@kenzieschmoll
Copy link
Member Author

(I don't know if dimension10 needs adding to some analytics account somewhere, but I presume if it does that will be done too)

Yep - it needed to be added to our analytics 360 account, and that has been completed too.

@kenzieschmoll kenzieschmoll merged commit b0597a3 into flutter:master Dec 1, 2021
@kenzieschmoll kenzieschmoll deleted the embedded branch December 1, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants