Add selection analytics for NetworkScreen #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Sep 14, 2021
jacob314
reviewed
Sep 14, 2021
|
|
||
| void _initTabController() { | ||
| _tabController?.removeListener(_onTabChanged); | ||
| _tabController?.dispose(); |
There was a problem hiding this comment.
I imagine we want to start tracking analytics on other cases we have tabs in DevTools. Would it make sense to define a AnalyticsTabController that handles logging the tab name each time a different tab is selected?
Seem annoying to have to change from a stateless to stateful widget just to make tabs work with our analytics.
There was a problem hiding this comment.
Done - Added AnalyticsTabbedView that handles sending tab switches to analytics.
jacob314
approved these changes
Sep 14, 2021
elliette
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #3270.
This PR tracks selections for the network profiler controls (pause, resume, clear) as well as for tab changes on the request inspector to understand usage of the different request inspector views.