Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for ios profiling issue and link to workaround. #3311

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

kenzieschmoll
Copy link
Member

This message will appear when a user records an empty profile on an iOS device.

Screen Shot 2021-08-27 at 12 07 18 PM

The link links to flutter/flutter#88466 (comment).

cc @jmagman @zanderso

@kenzieschmoll kenzieschmoll requested a review from jacob314 August 27, 2021 19:15
@kenzieschmoll
Copy link
Member Author

unrelated - @mariamhas here is an example of where we need an inline link and how we implement using TextSpans.

@zanderso
Copy link
Member

Message and flow lgtm, thanks!

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenzieschmoll kenzieschmoll merged commit c144ef7 into flutter:master Aug 27, 2021
@kenzieschmoll kenzieschmoll deleted the ios-workaround branch August 27, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants