Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel timeline polling timer when the vmService is closed #3304

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

kenzieschmoll
Copy link
Member

Without this call, the timeline polling timer is never cancelled when the vm service disconnects.

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenzieschmoll kenzieschmoll changed the title Dispose the performance controller when the vmService is closed Cancel timeline polling timer when the vmService is closed Aug 24, 2021
@kenzieschmoll kenzieschmoll merged commit fb7d2f9 into flutter:master Aug 24, 2021
@kenzieschmoll kenzieschmoll deleted the polling branch August 24, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants