Performance improvements for the CPU profiler #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Aug 13, 2021
|
|
||
| bool get isFlutterCore => | ||
| _isFlutterCore ??= processedUrl.startsWith('package:flutter/') || | ||
| name.startsWith('flutter::') || |
There was a problem hiding this comment.
nit: maybe make these constants so you have an easy place to document that
flutter:: is the Flutter namespace in C++?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent introduction of profile filtering added more calls to
getSimplePackageUrlthan we would have liked. This PR improves the performance of the profiler by caching some values:processedUrlreturned bygetSimplePackageUrlfor a stack frame. We then pass this value as a parameter during stack frame copy operations (we were previously computing it for every copy, which is unnecessary).isNative,isDartCore, andisFlutterCorevalues for a single stack frame. These no longer have to be re-computed for filter operations.