Add some analytics to the memory screen and clean up code. #3272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Aug 13, 2021
| @@ -207,7 +172,10 @@ class MemoryBodyState extends State<MemoryBody> | |||
| addAutoDisposeListener(controller.androidChartVisibleNotifier, () { | |||
| setState(() { | |||
| if (controller.androidChartVisibleNotifier.value) { | |||
| MemoryScreen.gaAction(key: MemoryScreen.androidChartButtonKey); | |||
| ga.select( | |||
There was a problem hiding this comment.
maybe add a helper to DevTools screen that
always passes in the analytics constant for the current screen?
There was a problem hiding this comment.
This is tricky because the calls to ga.select do not happen in the Widget subclasses of Screen. At the time that we call ga.select, we often times do not even have access to the Screen object, which is why we would have to get the id from a static method on the screen class, but we don't have access to the screenId from a screen in a static context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #3270