Prepare for v2.5.0 release. #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tool/pubspec.yaml
Outdated
| @@ -2,7 +2,7 @@ name: devtools_repo | |||
| description: A repo management tool for DevTools. | |||
|
|
|||
| environment: | |||
| sdk: '>=2.12.0 <3.0.0' | |||
There was a problem hiding this comment.
is this change necessary? looks like this may be what is causing the bots to fail
There was a problem hiding this comment.
Certainly caused bots to not work. However, update_version.sh would not run without the sdk change e.g.
tool/update_version.dart:50:7: Error: Null safety features are disabled for this library.
Try removing the package language version or setting the language version to 2.12 or higher.
String? incrementVersion(String oldVersion) {
kenzieschmoll
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.