Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimenting with building against a specific flutter sdk #3197

Merged
merged 6 commits into from
Jul 20, 2021

Conversation

devoncarew
Copy link
Member

@devoncarew devoncarew commented Jul 13, 2021

experimenting with building against a specific flutter sdk:

  • remove some older (TRAVIS_OS_NAME) build file cruft
  • build and test against a specific flutter version (currently the most recent dev - 2.4.0-4.0.pre)
  • add a CI time check to validate that we're testing that flutter-version.txt is the same version that the CI is testing

@devoncarew devoncarew marked this pull request as ready for review July 19, 2021 19:48
@devoncarew
Copy link
Member Author

devoncarew commented Jul 19, 2021

After this, we might want to follow up with one or more of:

  • remove testing against dev, beta, and stable on this CI?
  • have a script to automatically populate flutter-sdk/ with the flutter sdk version from flutter-version.txt?
  • have the tool/build_release.sh script ensure that the flutter sdk in flutter-sdk/ is the same as that mentioned in flutter-version.txt?

cc @kenzieschmoll @jacob314

@@ -23,11 +22,11 @@ jobs:
fail-fast: false
matrix:
channel:
- master
# When updating this version, also update the version in flutter-version.txt.
- 2.4.0-4.0.pre
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment describing how often we need to update this and which version we should be selecting when we do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@devoncarew devoncarew merged commit 6679264 into flutter:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants