Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dense mode for inspector #3149

Merged
merged 17 commits into from
Jun 21, 2021
Merged

Add dense mode for inspector #3149

merged 17 commits into from
Jun 21, 2021
+123 −31

Conversation

helin24
Copy link
Member

@helin24 helin24 commented Jun 18, 2021 •
edited
Loading

not embedded + narrow view + dense mode:
Screen Shot 2021-06-21 at 11 14 12 AM

not embedded + narrow view + regular mode:
Screen Shot 2021-06-21 at 1 56 03 PM

not embedded + wide view + dense mode:
Screen Shot 2021-06-21 at 11 17 05 AM

not embedded + wide view + regular mode:
Screen Shot 2021-06-21 at 11 15 39 AM

embedded + narrow view:
Screen Shot 2021-06-21 at 3 07 47 PM

embedded + wide view:
Screen Shot 2021-06-21 at 3 08 27 PM

@kenzieschmoll
Copy link
Member

Looks like we can reduce the space between the expand all and collapse all buttons for dense mode as well as the space between the select widget mode and refresh buttons

kenzieschmoll
kenzieschmoll reviewed Jun 21, 2021
View reviewed changes
packages/devtools_app/lib/src/app.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/config_specific/ide_theme/ide_theme.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/common_widgets.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/theme.dart Outdated Show resolved Hide resolved
packages/devtools_app/lib/src/theme.dart Outdated Show resolved Hide resolved
@helin24
Copy link
Member Author

helin24 commented Jun 21, 2021

Looks like we can reduce the space between the expand all and collapse all buttons for dense mode as well as the space between the select widget mode and refresh buttons

This would definitely look better, but I'm not sure how to do this. It looks like maybe the image exceeds the width of the outline button and keeps some space in between?
Screen Shot 2021-06-21 at 9 57 51 AM

@kenzieschmoll
Copy link
Member

One more suggestion: make the include text width the same for the Select Widget Mode and Refresh Tree buttons

@helin24 helin24 changed the title Dense Add dense mode for inspector Jun 21, 2021
@helin24
Copy link
Member Author

helin24 commented Jun 21, 2021

Is there a way to allow the refresh button to expand again in the non-dense case?

There are test breakages and I'm not sure if there are golden files I need to update.

kenzieschmoll
kenzieschmoll approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the last couple comments are fixed

@helin24 helin24 merged commit e327990 into flutter:master Jun 21, 2021
@helin24 helin24 deleted the dense branch June 21, 2021 22:17
@kenzieschmoll kenzieschmoll mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helin24 @kenzieschmoll