Stop checking flutter version for connected app in flutter web apps #3066
Conversation
| // No need to check the flutter version for Flutter web apps, as the | ||
| // performance tools that consume [flutterVersionNow] are not available for | ||
| // flutter web apps. | ||
| if (isFlutterNativeAppNow) { |
There was a problem hiding this comment.
Can you file a bug tracking adding support for flutterVersion for Flutter web apps? At some point it would be useful if that worked for flutter web so devtools extension authors don't have to worry about this..
There was a problem hiding this comment.
oddly enough I just checked with the gallery flutter web app and the flutterVersion service does register as expected. I don't see anything here that would prevent this from being registered on the web https://github.com/flutter/flutter/blob/5c09eecd0d5ea428d163de12d12d6bd9a7a8b16c/packages/flutter_tools/lib/src/vmservice.dart#L221.
There was a problem hiding this comment.
@grouma is this only broken in g3?
There was a problem hiding this comment.
Likely for now as Flutter Tools and Webdev have tighter restrictions on DevTools.
This also makes the version checking code more safe by ensuring that the flutter version service is available before attempting to make a call to it.