Add support for system isolates to isolate selector while in VM developer mode #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oper mode - Removed 'Isolate' from the isolate selector, replaced with 'forking' icon for isolates and 'gear' for system isolates. - Added tooltip for the isolate selector: 'Selected Isolate'. - Added 'No source available' path for CodeView. - Disable various debugger controls for system isolates.
Comment on lines
+459
to
+461
| if (selectedIsolate.isSystemIsolate && !vmDeveloperModeEnabled) { | ||
| selectIsolate(_isolates.first.id); | ||
| } |
There was a problem hiding this comment.
does this also need to be called outside of the listener callback before _initIsolates(isolates) on l:464?
There was a problem hiding this comment.
Nope, this should only be necessary when we remove system isolates from the list of available isolates. This just makes sure that we change the selected isolate to one of the remaining isolates if we currently have a system isolate selected when VM developer mode is disabled.
kenzieschmoll
approved these changes
Apr 28, 2021
| @@ -250,6 +250,7 @@ class DebuggerController extends DisposableController | |||
| ValueListenable<List<ConsoleLine>> get stdio => _stdio; | |||
|
|
|||
| IsolateRef isolateRef; | |||
| bool get isSystemIsolate => isolateRef.isSystemIsolate; | |||
There was a problem hiding this comment.
should this be isolateRef?.isSystemIsolate in case isolateRef is null?
There was a problem hiding this comment.
Doesn't hurt to be safe. When are we migrating to null safety again...? :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip
Isolates + system isolates with icons
System isolate with source available
System isolate with no source available
