Add search in file functionality to the debugger code view. #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Apr 22, 2021
packages/devtools_app/lib/src/debugger/debugger_controller.dart
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @override | ||
| List<SourceToken> matchesForSearch(String search) { |
There was a problem hiding this comment.
Can we adjust this to search across lines?
There was a problem hiding this comment.
do you mean search for a query like 'hello world' where 'hello' is on line 1 and 'world' is on line 2?
There was a problem hiding this comment.
The latter. hello on line 1 and world on line two. I thought Chrome supported this but that doesn't seem to be the case. This is probably fine regardless.
There was a problem hiding this comment.
The IDEs don't support this type of search either, so I think it's on par if we leave as is.
grouma
approved these changes
Apr 23, 2021
|
Added tests for search matching logic. |
|
tests are passing except for flakes like 0.00% golden image diffs unrelated to this PR. Landing. |
This was referenced May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd+f / ctrl+f opens the search bar. Pressing escape or clicking the 'x' button hides the search bar and clears search results.
