Fix issue where first build of the VM Tools status bar would cause a null pointer exception #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not 100% sure this is the right approach here, but it does fix the issue. The other approach I tried involved statically initializing the controller in |
|
discussed offline - going to try a different approach that doesn't require adding the |
…null pointer exception `VMDeveloperToolsScreen` exposes a `ValueListenable` provided by the `VMDeveloperToolsController` in order to control the visibility of the isolate selector. Given that `VMDeveloperToolsScreen.showIsolateSelector` can be invoked before the static controller in `_VMDeveloperToolsScreenState` is initialized, a null pointer exception was being thrown when first building the VM Tools screen. This change updates `DevToolsScreen` to take either a `createController` callback or a pre-instantiated `controller`, allowing for the same instance of `VMDeveloperToolsController` to be used by `VMDeveloperToolsScreen` while also being exposed via `Provider`.
d44af36 to
d4507c4
Compare
|
Updated with new approach (and was able to drop the static controller in |
Comment on lines
50
to
52
| // Ensure that the current screen's state is initialized. In particular, | ||
| // make sure that the screen's controller is available before calling | ||
| // `currentScreen.showIsolateSelector`. |
kenzieschmoll
approved these changes
Apr 15, 2021
kenzieschmoll
approved these changes
Apr 15, 2021
|
Red bots caused by #2916 |
|
Landing on red because flaky bots are frustrating. |
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMDeveloperToolsScreenexposes aValueListenableprovided by theVMDeveloperToolsControllerin order to control the visibility of the isolate selector. Given thatVMDeveloperToolsScreen.showIsolateSelectorcan be invoked before the static controller in_VMDeveloperToolsScreenStateis initialized, a null pointer exception was being thrown when first building the VM Tools screen.This change updates
DevToolsScreento take either acreateControllercallback or a pre-instantiatedcontroller, allowing for the same instance ofVMDeveloperToolsControllerto be used byVMDeveloperToolsScreenwhile also being exposed viaProvider.