Improve file history picker UX #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -353,6 +353,9 @@ class FileNode extends TreeNode<FileNode> { | |||
| } | |||
|
|
|||
| class ScriptRefUtils { | |||
| static String fileName(ScriptRef scriptRef) => | |||
There was a problem hiding this comment.
wasn't this landed in your last PR?
There was a problem hiding this comment.
Yeh. Just need to merge master.
| scriptRef.uri, | ||
| overflow: TextOverflow.ellipsis, | ||
| maxLines: 1, | ||
| style: const TextStyle(fontSize: 14.0, color: Colors.grey), |
There was a problem hiding this comment.
can you used theme.subtleTextStyle here instead?
There was a problem hiding this comment.
also not sure if i missed this in your last PR, but if we are changing the color manually to gray there too, can we use subtle instead?
There was a problem hiding this comment.
I'll update it in this PR and land it here.
kenzieschmoll
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2784
Mirror the file picker UX in Chrome which shows file results in two lines, the first line is simply the file name, the second line is the entire path potentially truncated. This helps for very long files as it's difficult to distinguish between truncated file names, especially in the history workflow as we do not have a tooltip.