Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bubble and reset #2751

Merged
merged 8 commits into from
Feb 28, 2021
Merged

Bubble and reset #2751

merged 8 commits into from
Feb 28, 2021

Conversation

terrylucas
Copy link
Contributor

@terrylucas terrylucas commented Feb 28, 2021 •
edited
Loading

  • Fixed event pane symbol displayed when a monitor allocation reset occurs.

  • Fixed symbols for light mode as well.

  • Monitor track displays (light and dark mode):

    image
    image

  • Monitor reset displays (light and dark mode):

    image
    image

  • Added a animated bubble that appears to the left of the timestamp displayed when an allocation monitor happens. On initial change detection the bubble grows like a balloon then settles back to a bubble. After 5 seconds then the bubble will disappear.

    image

jacob314
jacob314 reviewed Feb 28, 2021
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment •
edited by terrylucas
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is going on with the empty file goldens? probably remove them from the CL or add tests and generate real goldens.

These aren't empty github filechange shows it as empty they are different.

@terrylucas
Copy link
Contributor Author

what is going on with the empty file goldens? probably remove them from the CL or add tests and generate real goldens.

@terrylucas
Copy link
Contributor Author

PTAL updated.

jacob314
jacob314 approved these changes Feb 28, 2021
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@terrylucas terrylucas merged commit d2c1d6b into flutter:master Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob314 jacob314 jacob314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrylucas @jacob314