Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flame chart scrolling polish #2745

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

kenzieschmoll
Copy link
Member

This makes it so you cannot scroll beyond the bounds of the scroll view. Without this, there is a distracting bounce back effect.

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Would be great to apply this to the Table views as well. The bounce is annoying on the logging view.

@kenzieschmoll kenzieschmoll merged commit 5542fc5 into flutter:master Feb 26, 2021
@kenzieschmoll kenzieschmoll deleted the flamecharts branch February 26, 2021 19:14
@kenzieschmoll
Copy link
Member Author

AFAICT there is not bounce on the table views? I just tried to reproduce with the logging table and I can't get it to bounce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants