Delete code to fallback to the dart:html version of the app. #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leave the index_fallback.html as an escape hatch to debug if users hit issues or IDEs need to fallback.
|
Fixes #2598 unless we are really crashing canvaskit. |
| import 'src/debugger/syntax_highlighter.dart'; | ||
| import 'src/preferences.dart'; | ||
|
|
||
| void main() async { | ||
| final defaultOnError = FlutterError.onError; |
There was a problem hiding this comment.
Can you please also submit a CL with this change to the internal main.dart file? That file is not updated as part of the roll.
There was a problem hiding this comment.
good news is as the files it depends on were deleted you should get a compile error as part of the next roll. I can do the next roll into internal and fix as part of that.
kenzieschmoll
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave the index_fallback.html as an escape hatch to debug if users hit issues or IDEs need to fallback.