Fix inspector scrollbars. #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
896cbf5 to
4282399
Compare
4282399 to
8980884
Compare
jacob314
commented
Feb 17, 2021
| @@ -69,6 +69,9 @@ class InspectorScreenBodyState extends State<InspectorScreenBody> | |||
| bool get enableButtons => | |||
| actionInProgress == false && connectionInProgress == false; | |||
|
|
|||
| static const summaryTreeKey = Key('Summary Tree'); | |||
There was a problem hiding this comment.
This helps ensure inspector tree state widgets are reused when they should which avoids a known bug in the flutter scrollbars as well as helping performance a little.
jacob314
commented
Feb 17, 2021
| row: row, | ||
| error: | ||
| widget.widgetErrors != null && inspectorRef != null | ||
| return LayoutBuilder( |
There was a problem hiding this comment.
make sure to view this change with hide whitespace diffs.
kenzieschmoll
approved these changes
Feb 17, 2021
| double get safeViewportHeight { | ||
| return _scrollControllerY.hasClients | ||
| ? _scrollControllerY.position.viewportDimension | ||
| : 1000.0; |
There was a problem hiding this comment.
put this in a const with a name that describes what it is
| return AnimatedBuilder( | ||
| animation: widget.offsetController, | ||
| builder: (context, child) { | ||
| // Compute a delta so that |
| child: Transform.translate( | ||
| offset: -offset, | ||
| child: child, | ||
| )), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspector rows are now aware of how much space they have in the viewable window so that we can do a better job highlighting rows like this:
fixing
#2684
and text truncates when it reaches the end of the visible area like this:
As a followup I'd like to polish how the erros are shown in the tree as.
Mostly fixes #2626
as we now truncate long lines with ... instead of broken wrapping.
Fixes
#2674
but adding keys so inspector state objects are reused better.