Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use VS code debugging icons in debugger #2693

Merged
merged 10 commits into from
Feb 11, 2021
Merged

Use VS code debugging icons in debugger #2693

merged 10 commits into from
Feb 11, 2021

Conversation

kenzieschmoll
Copy link
Member

Screen Shot 2021-02-10 at 10 04 06 AM
Screen Shot 2021-02-10 at 10 04 15 AM

@jacob314
Copy link
Contributor

Third party content needs to be under the third_party directory in its own packages.

@kenzieschmoll
Copy link
Member Author

Should we consider publishing this package outside of the devtools repo?

jacob314
jacob314 approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kenzieschmoll kenzieschmoll merged commit 4b1593b into flutter:master Feb 11, 2021
@kenzieschmoll kenzieschmoll deleted the debugger-icons branch February 11, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob314 jacob314 jacob314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenzieschmoll @jacob314