Add floating debugger controls when app is paused #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
Feb 4, 2021
packages/devtools_app/lib/src/debugger/debugger_controller.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Feb 4, 2021
| Container( | ||
| decoration: BoxDecoration( | ||
| border: Border( | ||
| left: i == 0 ? BorderSide(color: color) : BorderSide.none, |
There was a problem hiding this comment.
why is only the left side special cased and not the right side.?
There was a problem hiding this comment.
We do this to make sure there are not any double borders. The right side of the previous element will serve as the left border for the next element (for all except the first since the first does not have a previous element)
jacob314
reviewed
Feb 4, 2021
jacob314
reviewed
Feb 4, 2021
| return ValueListenableBuilder<bool>( | ||
| valueListenable: controller.isPaused, | ||
| builder: (context, paused, _) { | ||
| if (!paused) return const SizedBox(); |
There was a problem hiding this comment.
nit: rather than having this become a sized box when not paused consider making the ui unclickable when not paused and providing an animated transition showing and hiding the ui.
There was a problem hiding this comment.
good idea. done - see pr description for gif
jacob314
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will show up when an app is paused (except when the debugger screen is the current screen)
Fixes #2377
Fixes #2547