Badge inspector tab for structured inspector errors (Flutter.error) #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
commented
Dec 29, 2020
|
|
||
| final json = e.extensionData.data; | ||
| final objectId = json['objectId'] as String; | ||
| if (objectId?.contains('inspector-') ?? false) { |
There was a problem hiding this comment.
will this check include things we don't want to badge the inspector for? @jacob314
There was a problem hiding this comment.
All object ids sent with errors will start with inspector- currently so this won't really check for much. I think just assuming any case with an objectId is an inspector error is fine for now. We could add a TODO to verify that the objectId is referring to an Element or Widget (may require another round trip unless the json also contains the object type which it may.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #173